-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs(release): update release docs #5893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(release): update release docs #5893
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Pull Request Test Coverage Report for Build 18457971239Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <[email protected]>
/retest |
Signed-off-by: ivan katliarchuk <[email protected]>
@@ -0,0 +1,164 @@ | |||
# 🧭 External-DNS Version Upgrade Playbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
docs/release.md
Outdated
External-DNS follows semantic versioning principles: | ||
|
||
- `0.x` → pre-stable, APIs subject to change. | ||
- `1.x` → stable APIs and core functionality; breaking changes require a major bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather say that we never have v1.0, because I'm Go it means you should never change a public exposed thing (method, func, ... does not matter).
We try to be stable enough for users such that features like source, annotations and providers don't break without migration path or we call it a bug that we want to fix as soon as possible (so fast as our time permits no eta).
Users should check each minor version release notes to the v0.x.0 release page which will explain how to migrate a breaking change without an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Updated
* master: update test certs used for pdns (kubernetes-sigs#5902) chore(controller-gen): move tools under go tools (kubernetes-sigs#5878) refactor(source/wrappers): move wrappers logic away from execute file (kubernetes-sigs#5888) chore(deps): bump the dev-dependencies group with 2 updates (kubernetes-sigs#5895) chore(deps): bump renovatebot/github-action (kubernetes-sigs#5890)
Signed-off-by: ivan katliarchuk <[email protected]>
Co-authored-by: Michel Loiseleur <[email protected]>
```yaml | ||
args: | ||
- --dry-run | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```yaml | |
args: | |
- --dry-run | |
``` | |
```yaml | |
args: | |
- --dry-run | |
``` |
```yaml | ||
args: | ||
- --dry-run | ||
- ...other flags | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```yaml | |
args: | |
- --dry-run | |
- ...other flags | |
``` | |
```yaml | |
args: | |
- --dry-run | |
- ...other flags | |
``` |
```sh | ||
dig +short myapp.example.com | ||
nslookup api.staging.example.com | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```sh | |
dig +short myapp.example.com | |
nslookup api.staging.example.com | |
``` | |
```sh | |
dig +short myapp.example.com | |
nslookup api.staging.example.com | |
``` |
What does it do ?
Update release docs and added best practices how to release.
Motivation
Quite often users do update minor versions, with the expectation, that breaking changes are only in major version, that we not yet planning.
More